← Commit list

aa7da7388

Denys Vlasenko
Denys Vlasenko
2009-09-13
FAILED Duration: 31s

Subject

add USE_PORTABLE_CODE option and use it in find applet

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

Config.in+8 -0
@@ -30,6 +30,14 @@ config EXTRA_COMPAT
some GNU extensions in libc. You probably only need this option
if you plan to run busybox on desktop.
+config USE_PORTABLE_CODE
+ bool "Avoid using GCC-specific code constructs"
+ default n
+ help
+ Use this option if you are trying to compile busybox with
+ compiler other than gcc.
+ If you do use gcc, this option may needlessly increase code size.
+
choice
prompt "Buffer allocation policy"
default FEATURE_BUFFERS_USE_MALLOC
findutils/find.c+4 -0
@@ -276,7 +276,11 @@ ACTF(inum)
ACTF(exec)
{
int i, rc;
+#if ENABLE_USE_PORTABLE_CODE
+ char **argv = alloca(sizeof(char*) * (ap->exec_argc + 1));
+#else /* gcc 4.3.1 generates smaller code: */
char *argv[ap->exec_argc + 1];
+#endif
for (i = 0; i < ap->exec_argc; i++)
argv[i] = subst(ap->exec_argv[i], ap->subst_count[i], fileName);
argv[i] = NULL; /* terminate the list */