ab8736064

Rob Landley

2006-04-04

SOURCE BUG Duration: 26s

Subject

You'd think there'd be a compiler warning for "pointless if", wouldn't you?

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

util-linux/mount.c +3 -3

util-linux/mount.c+3 -3

@@ -291,11 +291,11 @@ static int singlemount(struct mntent *mp)
	}
	}

-	// Look at the file. (Not found isn't a failure for remount.)
+	// Look at the file. (Not found isn't a failure for remount, or for
+	// a synthetic filesystem like proc or sysfs.)

	if (lstat(mp->mnt_fsname, &st));
-
-	if (!(vfsflags & (MS_REMOUNT \| MS_BIND \| MS_MOVE))) {
+	else if (!(vfsflags & (MS_REMOUNT \| MS_BIND \| MS_MOVE))) {
	// Do we need to allocate a loopback device for it?

	if (ENABLE_FEATURE_MOUNT_LOOP && S_ISREG(st.st_mode)) {