ab8c9378c
Denis Vlasenko
2007-09-28
Subject
more "if (p) free(p)" fixes; fix a typo in comment
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
libbb/getopt32.c+1 -1
| @@ -30,7 +30,7 @@ getopt32(char **argv, const char *applet_opts, ...) | |
| "r" will add 1 (bit 0) | |
| "n" will add 2 (bit 1) | |
| - | "u will add 4 (bit 2) |
| + | "u" will add 4 (bit 2) |
| "g" will add 8 (bit 3) | |
| and so on. You can also look at the return value as a bit | |
libbb/procps.c+6 -12
| @@ -353,14 +353,10 @@ procps_status_t *procps_scan(procps_status_t* sp, int flags) | |
| #if 0 /* PSSCAN_CMD is not used */ | |
| if (flags & (PSSCAN_CMD|PSSCAN_ARGV0)) { | |
| - | if (sp->argv0) { |
| - | free(sp->argv0); |
| - | sp->argv0 = NULL; |
| - | } |
| - | if (sp->cmd) { |
| - | free(sp->cmd); |
| - | sp->cmd = NULL; |
| - | } |
| + | free(sp->argv0); |
| + | sp->argv0 = NULL; |
| + | free(sp->cmd); |
| + | sp->cmd = NULL; |
| strcpy(filename_tail, "/cmdline"); | |
| /* TODO: to get rid of size limits, read into malloc buf, | |
| * then realloc it down to real size. */ | |
| @@ -380,10 +376,8 @@ procps_status_t *procps_scan(procps_status_t* sp, int flags) | |
| } | |
| #else | |
| if (flags & PSSCAN_ARGV0) { | |
| - | if (sp->argv0) { |
| - | free(sp->argv0); |
| - | sp->argv0 = NULL; |
| - | } |
| + | free(sp->argv0); |
| + | sp->argv0 = NULL; |
| strcpy(filename_tail, "/cmdline"); | |
| n = read_to_buf(filename, buf); | |
| if (n <= 0) | |