aecabffb8

Denis Vlasenko

2006-09-30

SOURCE BUG Duration: 64s

Subject

dpkg: fix use-after-free (bug 939)

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

archival/dpkg.c +4 -7

archival/dpkg.c+4 -7

@@ -304,16 +304,13 @@ static int version_compare(const unsigned int ver1, const unsigned int ver2)
	deb_ver2++;
	}
	result = version_compare_part(upstream_ver1, upstream_ver2);
+	if (!result)
+	/* Compare debian versions */
+	result = version_compare_part(deb_ver1, deb_ver2);

	free(upstream_ver1);
	free(upstream_ver2);
-
-	if (result != 0) {
-	return result;
-	}
-
-	/* Compare debian versions */
-	return version_compare_part(deb_ver1, deb_ver2);
+	return result;
	}

	static int test_version(const unsigned int version1, const unsigned int version2, const unsigned int operator)