af12cb39d

Rob Landley

2006-06-27

SOURCE BUG Duration: 45s

Subject

Patch from Geoff Baker to fix bug http://bugs.busybox.net/view.php?id=905 by changing wget's ftp code not to chdir but to use the complete path each time.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/wget.c +3 -19

networking/wget.c+3 -19

@@ -6,27 +6,12 @@
	*
	*/

-	#include <stdio.h>
+	#include "busybox.h"
	#include <errno.h>
-	#include <stdlib.h>
-	#include <unistd.h>
-	#include <ctype.h>
-	#include <string.h>
-	#include <strings.h>
-	#include <unistd.h>
	#include <signal.h>
	#include <sys/ioctl.h>
-
-	#include <sys/types.h>
-	#include <sys/stat.h>
-	#include <sys/socket.h>
-	#include <netinet/in.h>
-	#include <arpa/inet.h>
-	#include <netdb.h>
-
	#include <getopt.h>

-	#include "busybox.h"

	struct host_info {
	char *host;
@@ -458,13 +443,12 @@ read_response:
	close_delete_and_die("ftp login: %s", buf+4);
	}

-	ftpcmd("CDUP", NULL, sfp, buf);
	ftpcmd("TYPE I", NULL, sfp, buf);

	/*
	* Querying file size
	*/
-	if (ftpcmd("SIZE /", target.path, sfp, buf) == 213) {
+	if (ftpcmd("SIZE ", target.path, sfp, buf) == 213) {
	unsigned long value;
	if (safe_strtoul(buf+4, &value)) {
	close_delete_and_die("SIZE value is garbage");
@@ -496,7 +480,7 @@ read_response:
	filesize -= beg_range;
	}

-	if (ftpcmd("RETR /", target.path, sfp, buf) > 150)
+	if (ftpcmd("RETR ", target.path, sfp, buf) > 150)
	close_delete_and_die("RETR: %s", buf+4);
	}