← Commit list

af45760cc

Bernhard Reutner-Fischer
Bernhard Reutner-Fischer
2007-01-20
FAILED Duration: 3s

Subject

- get_terminal_width_height does not and should never write to fd. Cosmetic Precaution

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

include/libbb.h+1 -1
@@ -570,7 +570,7 @@ extern void vfork_daemon(int nochdir, int noclose);
extern void vfork_daemon_rexec(int nochdir, int noclose,
int argc, char **argv, char *foreground_opt);
#endif
-extern int get_terminal_width_height(int fd, int *width, int *height);
+extern int get_terminal_width_height(const int fd, int *width, int *height);
int is_in_ino_dev_hashtable(const struct stat *statbuf, char **name);
void add_to_ino_dev_hashtable(const struct stat *statbuf, const char *name);
libbb/xfuncs.c+1 -1
@@ -572,7 +572,7 @@ void xstat(char *name, struct stat *stat_buf)
/* It is perfectly ok to pass in a NULL for either width or for
* height, in which case that value will not be set. */
-int get_terminal_width_height(int fd, int *width, int *height)
+int get_terminal_width_height(const int fd, int *width, int *height)
{
struct winsize win = { 0, 0, 0, 0 };
int ret = ioctl(fd, TIOCGWINSZ, &win);