af5d00866
Denys Vlasenko
2017-08-07
Subject
expr: make it NOEXEC
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
NOFORK_NOEXEC.lst+2 -2
| @@ -108,12 +108,12 @@ dumpleases - leaks: open+xread | |
| echo - NOFORK | |
| ed - interactive, longterm | |
| egrep - longterm runner ("CMD | egrep ..." may run indefinitely, better to exec to conserve memory) | |
| - | eject - leaks: open+ioctl_or_perror_and_die, changes state (moves fds) |
| + | eject - hardware, leaks: open+ioctl_or_perror_and_die, changes state (moves fds) |
| env - noexec. spawner, changes state (env) | |
| envdir - noexec. spawner | |
| envuidgid - noexec. spawner | |
| expand - runner | |
| - | expr - leaks: nested allocs |
| + | expr - noexec. leaks: nested allocs |
| factor - runner (eats stdin if no params) | |
| fakeidentd - daemon | |
| false - NOFORK | |
coreutils/expr.c+5 -2
| @@ -38,7 +38,7 @@ | |
| //config: the applet slightly larger, but will allow computation with very | |
| //config: large numbers. | |
| - | //applet:IF_EXPR(APPLET(expr, BB_DIR_USR_BIN, BB_SUID_DROP)) |
| + | //applet:IF_EXPR(APPLET_NOEXEC(expr, expr, BB_DIR_USR_BIN, BB_SUID_DROP, expr)) |
| //kbuild:lib-$(CONFIG_EXPR) += expr.o | |
| @@ -118,7 +118,10 @@ struct globals { | |
| char **args; | |
| } FIX_ALIASING; | |
| #define G (*(struct globals*)bb_common_bufsiz1) | |
| - | #define INIT_G() do { setup_common_bufsiz(); } while (0) |
| + | #define INIT_G() do { \ |
| + | setup_common_bufsiz(); \ |
| + | /* NB: noexec applet - globals not zeroed */ \ |
| + | } while (0) |
| /* forward declarations */ | |
| static VALUE *eval(void); | |