b323162aa

Glenn L McGrath

2002-12-11

SOURCE BUG Duration: 5s

Subject

Use libbb/get_line_from_file instead of getline

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): sysdeps/linux/Config.in "fileutils/Config.in" dosyasini kaynak gosteriyor ama bu dosya repoda hic var olmadi (2002-12-05 - 2003-02-15 arasi orijinal yazar hatasi, 3238ea167 ile duzeltildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

archival/dpkg.c +2 -4

archival/dpkg.c+2 -4

@@ -1057,7 +1057,6 @@ char *create_list(const char filename)
	FILE *list_stream;
	char **file_list = NULL;
	char *line = NULL;
-	int length = 0;
	int count = 0;

	/* dont use [xw]fopen here, handle error ourself */
@@ -1066,14 +1065,13 @@ char *create_list(const char filename)
	return(NULL);
	}

-	while (getline(&line, &length, list_stream) != -1) {
+	while ((line = get_line_from_file(list_stream)) != NULL) {
	file_list = xrealloc(file_list, sizeof(char ) (count + 2));
	chomp(line);
-	file_list[count] = xstrdup(line);
+	file_list[count] = line;
	count++;
	}
	fclose(list_stream);
-	free(line);

	if (count == 0) {
	return(NULL);