b750dec40

Denis Vlasenko

2006-09-07

SOURCE BUG Duration: 39s

Subject

fix if (ENABLE_FEATURE_SYSLOG & (...)) - should be &&

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/verror_msg.c +1 -1 libbb/vinfo_msg.c +1 -1

libbb/verror_msg.c+1 -1

@@ -32,7 +32,7 @@ void bb_verror_msg(const char s, va_list p, const char strerr)
	else
	fprintf(stderr, ": %s\n", strerr);
	}
-	if (ENABLE_FEATURE_SYSLOG & (logmode & LOGMODE_SYSLOG)) {
+	if (ENABLE_FEATURE_SYSLOG && (logmode & LOGMODE_SYSLOG)) {
	if (!strerr)
	vsyslog(LOG_ERR, s, p2);
	else {

libbb/vinfo_msg.c+1 -1

@@ -24,7 +24,7 @@ void bb_vinfo_msg(const char *s, va_list p)
	vprintf(s, p);
	putchar('\n');
	}
-	if (ENABLE_FEATURE_SYSLOG & (logmode & LOGMODE_SYSLOG))
+	if (ENABLE_FEATURE_SYSLOG && (logmode & LOGMODE_SYSLOG))
	vsyslog(LOG_INFO, s, p2);
	va_end(p2);
	}