← Commit list

bbf1e3c14

Denys Vlasenko
Denys Vlasenko
2012-02-05
FAILED Duration: 208s

Subject

acpid: do not install handlers for fatal signals

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

util-linux/acpid.c+6 -2
@@ -268,8 +268,12 @@ int acpid_main(int argc UNUSED_PARAM, char **argv)
xchdir(opt_dir);
+ /* We spawn children but don't wait for them. Prevent zombies: */
bb_signals((1 << SIGCHLD), SIG_IGN);
- bb_signals(BB_FATAL_SIGS, record_signo);
+ // If you enable this, (1) explain why, (2)
+ // make sure while(poll) loop below is still interruptible
+ // by SIGTERM et al:
+ //bb_signals(BB_FATAL_SIGS, record_signo);
pfd = NULL;
nfd = 0;
@@ -337,7 +341,7 @@ int acpid_main(int argc UNUSED_PARAM, char **argv)
}
if (!event)
continue;
- // spawn event handler
+ /* spawn event handler */
process_event(event);
}
}