bc059bc7f

Rob Landley

2006-01-10

SOURCE BUG Duration: 9s

Subject

The brain-dead FTP servers on Solaris don't support the size command.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/ftpgetput.c +9 -2

networking/ftpgetput.c+9 -2

@@ -143,6 +143,9 @@ static int ftp_recieve(ftp_host_info_t server, FILE control_stream,
	if (safe_strtoul(buf + 4, &value))
	bb_error_msg_and_die("SIZE error: %s", buf + 4);
	filesize = value;
+	} else {
+	filesize = -1;
+	do_continue = 0;
	}

	if ((local_path[0] == '-') && (local_path[1] == '\0')) {
@@ -185,8 +188,12 @@ static int ftp_recieve(ftp_host_info_t server, FILE control_stream,
	}

	/* Copy the file */
-	if (bb_copyfd_size(fd_data, fd_local, filesize) == -1) {
-	exit(EXIT_FAILURE);
+	if (filesize != -1) {
+	if (-1 == bb_copyfd_size(fd_data, fd_local, filesize))
+	exit(EXIT_FAILURE);
+	} else {
+	if (-1 == bb_copyfd_eof(fd_data, fd_local))
+	exit(EXIT_FAILURE);
	}

	/* close it all down */