← Commit list

bc2c1b4f8

Denys Vlasenko
Denys Vlasenko
2020-12-20
SUCCESS Duration: 150s

Subject

ping: fix -wN to not think that one packet is always lost

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/ping.c+4 -5
@@ -471,17 +471,16 @@ static void sendping_tail(void (*sp)(int), int size_pkt)
{
int sz;
- CLR((uint16_t)G.ntransmitted % MAX_DUP_CHK);
- G.ntransmitted++;
-
- size_pkt += datalen;
-
if (G.deadline_us) {
unsigned n = G.cur_us - G.deadline_us;
if ((int)n >= 0)
print_stats_and_exit(0);
}
+ CLR((uint16_t)G.ntransmitted % MAX_DUP_CHK);
+ G.ntransmitted++;
+ size_pkt += datalen;
+
/* sizeof(pingaddr) can be larger than real sa size, but I think
* it doesn't matter */
sz = xsendto(pingsock, G.snd_packet, size_pkt, &pingaddr.sa, sizeof(pingaddr));