be507170e

Denis Vlasenko

2006-09-14

SOURCE BUG Duration: 42s

Subject

mount: -o remount should not add lines to /etc/mtab

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

util-linux/mount.c +1 -1

util-linux/mount.c+1 -1

@@ -222,7 +222,7 @@ static int mount_it_now(struct mntent mp, int vfsflags, char filteropts)
	/* If the mount was successful, and we're maintaining an old-style
	* mtab file by hand, add the new entry to it now. */

-	if(ENABLE_FEATURE_MTAB_SUPPORT && useMtab && !rc) {
+	if(ENABLE_FEATURE_MTAB_SUPPORT && useMtab && !rc && !(vfsflags & MS_REMOUNT)) {
	char dirbuf[PATH_MAX];
	char srcbuf[PATH_MAX];
	FILE *mountTable = setmntent(bb_path_mtab_file, "a+");