bf2d9905c

Mike Frysinger

2006-04-16

SOURCE BUG Duration: 32s

Subject

use xmalloc, dont hardcode length of string, and get rid of pointless call to memset

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

miscutils/less.c +2 -3

miscutils/less.c+2 -3

@@ -625,12 +625,11 @@ static char process_regex_on_line(char line, regex_t *pattern)
	insert_highlights, and then the line is returned. */

	int match_status;
-	char line2 = (char ) malloc((sizeof(char) * (strlen(line) + 1)) + 64);
+	char line2 = (char ) xmalloc((sizeof(char) * (strlen(line) + 1)) + 64);
	char sub_line[256];
	int prev_eo = 0;
	regmatch_t match_structs;

-	memset(sub_line, 0, 256);
	strcpy(line2, line);

	match_found = 0;
@@ -638,7 +637,7 @@ static char process_regex_on_line(char line, regex_t *pattern)

	while (match_status == 0) {

-	memset(sub_line, 0, 256);
+	memset(sub_line, 0, sizeof(sub_line));

	if (match_found == 0)
	match_found = 1;