← Commit list

bf39216cc

Denis Vlasenko
Denis Vlasenko
2006-10-15
FAILED Duration: 4s

Subject

grep: -r didn't close files, producing "Too many open files"

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

findutils/grep.c+2 -1
@@ -301,6 +301,7 @@ static int file_action_grep(const char *filename, struct stat *statbuf, void* ma
}
cur_file = filename;
*(int*)matched += grep_file(file);
+ fclose(file);
return 1;
}
@@ -446,13 +447,13 @@ int grep_main(int argc, char **argv)
}
}
matched += grep_file(file);
+ bb_fclose_nonstdin(file);
grep_done:
if (matched < 0) {
/* we found a match but were told to be quiet, stop here and
* return success */
break;
}
- bb_fclose_nonstdin(file);
}
/* destroy all the elments in the pattern list */