c05dda4b2

Rob Landley

2006-03-03

SOURCE BUG Duration: 14s

Subject

Denis Vlasenko noticed that falign=0 is meaningless, and that should probably be falign=1. Saves a little over 3k on an x86 "make defconfig" build.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

Rules.mak +1 -1

Rules.mak+1 -1

@@ -190,7 +190,7 @@ $(if $(call is_eq,$(__TARGET_ARCH),i386),\
	# gcc-4.0 and older seem to suffer from these
	$(if $(call cc_le,4,0),\
	$(call check_gcc,OPTIMIZATIONS,-mpreferred-stack-boundary=2,)\
-	$(call check_gcc,OPTIMIZATIONS,-falign-functions=0 -falign-jumps=0 -falign-loops=0,\
+	$(call check_gcc,OPTIMIZATIONS,-falign-functions=1 -falign-jumps=1 -falign-loops=1,\
	-malign-functions=0 -malign-jumps=0 -malign-loops=0))

	# gcc-4.1 and beyond seem to benefit from these