← Commit list

c67ff8a1b

Denys Vlasenko
Denys Vlasenko
2018-12-10
SUCCESS Duration: 151s

Subject

tls: fix a potential (currently "disabled" by a macro) SHA1-related bug

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/tls.c +1 -1
networking/tls.c+1 -1
@@ -525,7 +525,7 @@ static unsigned hmac(tls_state_t *tls, uint8_t *out, uint8_t *key, unsigned key_
va_start(va, key_size);
hmac_begin(&pre, key, key_size,
- (ENABLE_FEATURE_TLS_SHA1 || tls->MAC_size == SHA256_OUTSIZE)
+ (!ENABLE_FEATURE_TLS_SHA1 || tls->MAC_size == SHA256_OUTSIZE)
? sha256_begin
: sha1_begin
);