c8ab67cad
Denys Vlasenko
2009-05-10
Subject
tftp: do not risk invoking Sorcerer's Apprentice syndrome
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
examples/udhcp/simple.script+1 -1
| @@ -3,7 +3,7 @@ | |
| RESOLV_CONF="/etc/resolv.conf" | |
| - | [ -n "$1" ] || echo "Error: should be called from udhcpc" && exit 1 |
| + | [ -n "$1" ] || { echo "Error: should be called from udhcpc"; exit 1; } |
| NETMASK="" | |
| [ -n "$subnet" ] && NETMASK="netmask $subnet" | |
networking/tftp.c+3 -0
| @@ -501,11 +501,14 @@ static int tftp_protocol( | |
| } | |
| continue; /* send ACK */ | |
| } | |
| + | /* Disabled to cope with servers with Sorcerer's Apprentice Syndrome */ |
| + | #if 0 |
| if (recv_blk == (block_nr - 1)) { | |
| /* Server lost our TFTP_ACK. Resend it */ | |
| block_nr = recv_blk; | |
| continue; | |
| } | |
| + | #endif |
| } | |
| if (CMD_PUT(option_mask32) && (opcode == TFTP_ACK)) { | |