← Commit list

d16e612c9

Denys Vlasenko
Denys Vlasenko
2017-08-11
SUCCESS Duration: 142s

Subject

hush: fix redirect code (was using uninitialized variables)

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

shell/hush.c+4 -2
@@ -6741,7 +6741,8 @@ static struct squirrel *add_squirrel(struct squirrel *sq, int fd, int avoid_fd)
int moved_to;
int i;
- if (sq) for (i = 0; sq[i].orig_fd >= 0; i++) {
+ i = 0;
+ if (sq) for (; sq[i].orig_fd >= 0; i++) {
/* If we collide with an already moved fd... */
if (fd == sq[i].moved_to) {
sq[i].moved_to = fcntl_F_DUPFD(sq[i].moved_to, avoid_fd);
@@ -6769,7 +6770,8 @@ static struct squirrel *add_squirrel_closed(struct squirrel *sq, int fd)
{
int i;
- if (sq) for (i = 0; sq[i].orig_fd >= 0; i++) {
+ i = 0;
+ if (sq) for (; sq[i].orig_fd >= 0; i++) {
/* If we collide with an already moved fd... */
if (fd == sq[i].orig_fd) {
/* Examples: