d3d829aaf

"Vladimir N. Oleynik"

2005-10-15

SOURCE BUG Duration: 7s

Subject

20 bytes data to bss

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

sysklogd/syslogd.c +4 -6

sysklogd/syslogd.c+4 -6

@@ -319,9 +319,8 @@ static void message(char *fmt, ...)

	} else
	#endif
-	if ((fd =
-	device_open(logFilePath,
-	O_WRONLY \| O_CREAT \| O_NOCTTY \| O_APPEND \|
+	if ((fd = device_open(logFilePath,
+	O_WRONLY \| O_CREAT \| O_NOCTTY \| O_APPEND \|
	O_NONBLOCK)) >= 0) {
	fl.l_type = F_WRLCK;
	fcntl(fd, F_SETLKW, &fl);
@@ -363,8 +362,7 @@ static void message(char *fmt, ...)
	close(fd);
	} else {
	/* Always send console messages to /dev/console so people will see them. */
-	if ((fd =
-	device_open(_PATH_CONSOLE,
+	if ((fd = device_open(_PATH_CONSOLE,
	O_WRONLY \| O_NOCTTY \| O_NONBLOCK)) >= 0) {
	va_start(arguments, fmt);
	vdprintf(fd, fmt, arguments);
@@ -400,7 +398,7 @@ static void logMessage(int pri, char *msg)
	{
	time_t now;
	char *timestamp;
-	static char res[20] = "";
+	static char res[20];
	#ifdef CONFIG_FEATURE_REMOTE_LOG
	static char line[MAXLINE + 1];
	#endif