d6766c71a
Denis Vlasenko
2007-06-08
Subject
mdev: microscopic enhancement, should change nothing
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
util-linux/mdev.c+6 -8
| @@ -178,17 +178,15 @@ static void make_device(char *path, int delete) | |
| if (ENABLE_FEATURE_MDEV_CONF) chown(device_name, uid, gid); | |
| } | |
| if (command) { | |
| - | int rc; |
| - | char *s; |
| - | |
| - | s = xasprintf("MDEV=%s", device_name); |
| - | putenv(s); |
| - | rc = system(command); |
| - | s[4] = 0; |
| + | /* setenv will leak memory, so use putenv */ |
| + | char *s = xasprintf("MDEV=%s", device_name); |
| putenv(s); | |
| + | if (system(command) == -1) |
| + | bb_perror_msg_and_die("cannot run %s", command); |
| + | s[4] = '\0'; |
| + | unsetenv(s); |
| free(s); | |
| free(command); | |
| - | if (rc == -1) bb_perror_msg_and_die("cannot run %s", command); |
| } | |
| if (delete) unlink(device_name); | |
| } | |