d797fcd72

Denis Vlasenko

2006-09-09

SOURCE BUG Duration: 40s

Subject

udhcp: FEATURE_UDHCP_SYSLOG should be selected only if udhcp[cd] really are going to use it.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/udhcp/Config.in +1 -2

networking/udhcp/Config.in+1 -2

@@ -6,7 +6,6 @@
	config CONFIG_APP_UDHCPD
	bool "udhcp Server (udhcpd)"
	default n
-	select CONFIG_FEATURE_SYSLOG
	help
	uDHCPd is a DHCP server geared primarily toward embedded systems,
	while striving to be fully functional and RFC compliant.
@@ -27,7 +26,6 @@ config CONFIG_APP_DUMPLEASES
	config CONFIG_APP_UDHCPC
	bool "udhcp Client (udhcpc)"
	default n
-	select CONFIG_FEATURE_SYSLOG
	help
	uDHCPc is a DHCP client geared primarily toward embedded systems,
	while striving to be fully functional and RFC compliant.
@@ -41,6 +39,7 @@ config CONFIG_FEATURE_UDHCP_SYSLOG
	bool "Log udhcp messages to syslog"
	default n
	depends on CONFIG_APP_UDHCPD \|\| CONFIG_APP_UDHCPC
+	select CONFIG_FEATURE_SYSLOG
	help
	If not daemonized, udhcpd prints its messages to stdout/stderr.
	If this option is selected, it will also log them to syslog.