daf58ef61

Rob Landley

2006-08-04

SOURCE BUG Duration: 43s

Subject

Use xopen3() instead of an after-the-fact chown.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

archival/libunarchive/data_extract_all.c +2 -6

archival/libunarchive/data_extract_all.c+2 -6

@@ -58,7 +58,8 @@ void data_extract_all(archive_handle_t *archive_handle)
	switch(file_header->mode & S_IFMT) {
	case S_IFREG: {
	/* Regular file */
-	dst_fd = xopen(file_header->name, O_WRONLY \| O_CREAT \| O_EXCL);
+	dst_fd = xopen3(file_header->name, O_WRONLY \| O_CREAT \| O_EXCL,
+	file_header->mode);
	bb_copyfd_size(archive_handle->src_fd, dst_fd, file_header->size);
	close(dst_fd);
	break;
@@ -93,11 +94,6 @@ void data_extract_all(archive_handle_t *archive_handle)
	if (!(archive_handle->flags & ARCHIVE_NOPRESERVE_OWN)) {
	lchown(file_header->name, file_header->uid, file_header->gid);
	}
-	if (!(archive_handle->flags & ARCHIVE_NOPRESERVE_PERM) &&
-	(file_header->mode & S_IFMT) != S_IFLNK)
-	{
-	chmod(file_header->name, file_header->mode);
-	}

	if (archive_handle->flags & ARCHIVE_PRESERVE_DATE) {
	struct utimbuf t;