← Commit list

dce17c626

Mike Frysinger
Mike Frysinger
2006-02-19
SOURCE BUG Duration: 3s

Subject

rfelker writes in Bug 742: make sure string is null terminated after calling gethostname

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Debian 14.2.0-19) 14.2.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/login.c+2 -1
@@ -96,6 +96,7 @@ void print_login_issue(const char *issue_file, const char *tty)
case 'h':
gethostname(buf, sizeof(buf) - 1);
+ buf[sizeof(buf) - 1] = '\0';
break;
case 'l':
@@ -105,7 +106,7 @@ void print_login_issue(const char *issue_file, const char *tty)
default:
buf[0] = c;
}
- }
+ }
fputs(outbuf, stdout);
}