← Commit list

dd14ca082

"Vladimir N. Oleynik"
"Vladimir N. Oleynik"
2006-01-31
SOURCE BUG Duration: 2s

Subject

protect potential overflow for x86_64

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Debian 14.2.0-19) 14.2.0

—

Build Log

(log yok)

Commit Diff GitHub →

miscutils/last.c+3 -2
@@ -47,6 +47,7 @@ extern int last_main(int argc, char **argv)
{
struct utmp ut;
int n, file = STDIN_FILENO;
+ time_t t_tmp;
if (argc > 1) {
bb_show_usage();
@@ -98,9 +99,9 @@ extern int last_main(int argc, char **argv)
break;
}
}
-
+ t_tmp = (time_t)ut.ut_tv.tv_sec;
printf("%-10s %-14s %-18s %-12.12s\n", ut.ut_user, ut.ut_line, ut.ut_host,
- ctime((time_t *)&(ut.ut_tv.tv_sec)) + 4);
+ ctime(&t_tmp) + 4);
}
bb_fflush_stdout_and_exit(EXIT_SUCCESS);