deac37169

Paul Fox

2005-07-19

FAILED Duration: 27s

Subject

applying fix from: 0000088: inetd chargen stream does not generate the characters as recommended in RFC 864 Chragen service is generating garbage characters.

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/inetd.c +6 -6

networking/inetd.c+6 -6

@@ -1092,10 +1092,10 @@ static void chargen_stream(int s, servtab_t *sep)
	text[LINESIZ + 1] = '\n';
	for (rs = ring;;) {
	if ((len = endring - rs) >= LINESIZ)
-	memcpy(rs, text, LINESIZ);
+	memcpy(text, rs, LINESIZ);
	else {
-	memcpy(rs, text, len);
-	memcpy(ring, text + len, LINESIZ - len);
+	memcpy(text, rs, len);
+	memcpy(text + len, ring, LINESIZ - len);
	}
	if (++rs == endring)
	rs = ring;
@@ -1125,10 +1125,10 @@ static void chargen_dg(int s, servtab_t *sep)
	return;

	if ((len = endring - rs) >= LINESIZ)
-	memcpy(rs, text, LINESIZ);
+	memcpy(text, rs, LINESIZ);
	else {
-	memcpy(rs, text, len);
-	memcpy(ring, text + len, LINESIZ - len);
+	memcpy(text, rs, len);
+	memcpy(text + len, ring, LINESIZ - len);
	}
	if (++rs == endring)
	rs = ring;