← Commit list

dfe6e7415

"Vladimir N. Oleynik"
"Vladimir N. Oleynik"
2006-01-31
SOURCE BUG Duration: 2s

Subject

changed strange mix signed<->unsigned

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Debian 14.2.0-19) 14.2.0

—

Build Log

(log yok)

Commit Diff GitHub →

editors/patch.c+4 -4
@@ -26,9 +26,9 @@
#include <unistd.h>
#include "busybox.h"
-static int copy_lines(FILE *src_stream, FILE *dest_stream, const unsigned int lines_count)
+static unsigned int copy_lines(FILE *src_stream, FILE *dest_stream, const unsigned int lines_count)
{
- int i = 0;
+ unsigned int i = 0;
while (src_stream && (i < lines_count)) {
char *line;
@@ -52,7 +52,7 @@ static int copy_lines(FILE *src_stream, FILE *dest_stream, const unsigned int li
* returns malloc'ed filename
*/
-static char *extract_filename(char *line, unsigned short patch_level)
+static char *extract_filename(char *line, int patch_level)
{
char *filename_start_ptr = line + 4;
int i;
@@ -90,7 +90,7 @@ static int file_doesnt_exist(const char *filename)
extern int patch_main(int argc, char **argv)
{
- unsigned int patch_level = -1;
+ int patch_level = -1;
char *patch_line;
int ret;
FILE *patch_file = NULL;