e2922e42a

Bernhard Reutner-Fischer

2006-05-19

SOURCE BUG Duration: 72s

Subject

- make it C89 compatible; Declarations in the middle of a function is of course fine in C99, but it really serves no purpose other than breaking compilation on C89 compilers. Thanks to Rich Felker for pointing this out.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

procps/top.c +4 -3

procps/top.c+4 -3

@@ -338,20 +338,21 @@ static void display_status(int count, int scr_width)
	while (count--) {
	div_t pmem = div( (s->rss*pmem_scale) >> pmem_shift, 10);
	int col = scr_width+1;
+	USE_FEATURE_TOP_CPU_USAGE_PERCENTAGE(div_t pcpu;)

	if (s->rss >= 100*1024)
	sprintf(rss_str_buf, "%6ldM", s->rss/1024);
	else
	sprintf(rss_str_buf, "%7ld", s->rss);
-	USE_FEATURE_TOP_CPU_USAGE_PERCENTAGE(div_t pcpu = div((s->pcpu*pcpu_scale) >> pcpu_shift, 10));
+	USE_FEATURE_TOP_CPU_USAGE_PERCENTAGE(pcpu = div((s->pcpu*pcpu_scale) >> pcpu_shift, 10);)
	col -= printf("\n%5d %-8s %s %s%6d%3u.%c" \
-	USE_FEATURE_TOP_CPU_USAGE_PERCENTAGE("%3u.%c") " ",
+	USE_FEATURE_TOP_CPU_USAGE_PERCENTAGE("%3u.%c") " ",
	s->pid, s->user, s->state, rss_str_buf, s->ppid,
	USE_FEATURE_TOP_CPU_USAGE_PERCENTAGE(pcpu.quot, '0'+pcpu.rem,)
	pmem.quot, '0'+pmem.rem);
	if (col>0)
	printf("%.*s", col, s->short_cmd);
-	/* printf(" %d/%d %lld/%lld", s->pcpu, total_pcpu,
+	/* printf(" %d/%d %lld/%lld", s->pcpu, total_pcpu,
	jif.busy - prev_jif.busy, jif.total - prev_jif.total); */
	s++;
	}