e3484095f

Denys Vlasenko

2025-07-07

SOURCE BUG Duration: 82s

Subject

libbb/yescrypt: code shrink

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): libbb/yescrypt eklenirken (2025-07-06 - 2025-07-07 arasi) once unutulan kaynak dosyalari (pw_encrypt_yes.c, hash_sha256_block.c, pw_ascii64.c), ardindan 64-bit'te derlenmeyen bir 'buflen' degiskeni (alg-yescrypt-kdf.c) vardi - busybox'in kendi kodundaki gercek hatalar (e5d3a8763 ile duzeltildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

libbb/yescrypt/alg-yescrypt-common.c +3 -3

libbb/yescrypt/alg-yescrypt-common.c+3 -3

@@ -126,8 +126,8 @@ static const uint8_t *decode64(
	*dstlen = dstpos;
	dbg_dec64("dec64: OK, dst[%d]", (int)dstpos);
	return src;
-	fail:
-	*dstlen = 0;
+	fail:
+	/* dstlen = 0; - not needed, caller detects error by seeing NULL /
	return NULL;
	}
	#else
@@ -177,7 +177,7 @@ static const uint8_t *decode64(
	dbg_dec64("dec64: OK, dst[%d]", (int)dstpos);
	return src;
	}
-	fail:
+	fail:
	/* dstlen = 0; - not needed, caller detects error by seeing NULL /
	return NULL;
	}