e7f8a3292

Bernhard Reutner-Fischer

2006-04-11

SOURCE BUG Duration: 22s

Subject

- httpd in inetd mode: POST from IE (6) ends up in 'cannot display page' Closes #827

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/httpd.c +5 -5

networking/httpd.c+5 -5

@@ -1602,11 +1602,9 @@ static void handleIncoming(void)
	char *cookie = 0;
	char *content_type = 0;
	#endif
-	#ifndef CONFIG_FEATURE_HTTPD_USAGE_FROM_INETD_ONLY
	fd_set s_fd;
	struct timeval tv;
	int retval;
-	#endif
	struct sigaction sa;

	#ifdef CONFIG_FEATURE_HTTPD_BASIC_AUTH
@@ -1852,19 +1850,21 @@ FORBIDDEN: /* protect listing /cgi-bin */
	free(config->remoteuser);
	#endif
	# endif
+	#endif /* CONFIG_FEATURE_HTTPD_USAGE_FROM_INETD_ONLY */
	shutdown(a_c_w, SHUT_WR);

	/* Properly wait for remote to closed */
	FD_ZERO (&s_fd) ;
-	FD_SET (a_c_w, &s_fd) ;
+	FD_SET (a_c_r, &s_fd) ;

	do {
	tv.tv_sec = 2 ;
	tv.tv_usec = 0 ;
-	retval = select (a_c_w + 1, &s_fd, NULL, NULL, &tv);
-	} while (retval > 0 && (read (a_c_w, buf, sizeof (config->buf)) > 0));
+	retval = select (a_c_r + 1, &s_fd, NULL, NULL, &tv);
+	} while (retval > 0 && (read (a_c_r, buf, sizeof (config->buf)) > 0));

	shutdown(a_c_r, SHUT_RD);
+	#ifndef CONFIG_FEATURE_HTTPD_USAGE_FROM_INETD_ONLY
	close(config->accepted_socket);
	#endif /* CONFIG_FEATURE_HTTPD_USAGE_FROM_INETD_ONLY */
	}