ea7c18514

Rob Landley

2006-06-28

SOURCE BUG Duration: 49s

Subject

Fix http://bugs.busybox.net/view.php?id=826 in which "(echo; echo) | sed x" crashes because the empty state of the hold space is NULL but the empty state of the pattern space is "".

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

editors/sed.c +1 -1

editors/sed.c+1 -1

@@ -1054,7 +1054,7 @@ restart:
	case 'x': /* Exchange hold and pattern space */
	{
	char *tmp = pattern_space;
-	pattern_space = bbg.hold_space;
+	pattern_space = bbg.hold_space ? : xzalloc(1);
	no_newline=0;
	bbg.hold_space = tmp;
	break;