ea93f8a39

Mike Frysinger

2006-06-07

SOURCE BUG Duration: 60s

Subject

Tito writes: this patch fixes two potential bugs with the -i -I flags that could be reset during option parsing

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

miscutils/hdparm.c +2 -2

miscutils/hdparm.c+2 -2

@@ -2122,8 +2122,8 @@ int hdparm_main(int argc, char **argv)
	while ((c = getopt(argc, argv, hdparm_options)) >= 0) {
	flagcount++;
	if (c == 'h') bb_show_usage(); /* EXIT */
-	USE_FEATURE_HDPARM_GET_IDENTITY(get_IDentity = (c == 'I'));
-	USE_FEATURE_HDPARM_GET_IDENTITY(get_identity = (c == 'i'));
+	USE_FEATURE_HDPARM_GET_IDENTITY(get_IDentity \|= (c == 'I'));
+	USE_FEATURE_HDPARM_GET_IDENTITY(get_identity \|= (c == 'i'));
	get_geom \|= (c == 'g');
	do_flush \|= (c == 'f');
	if (c == 'u') parse_opts(&get_unmask, &set_unmask, &unmask, 0, 1);