ecb29573e

Rob Landley

2006-08-22

SOURCE BUG Duration: 29s

Subject

"Jordan Crouse" says: The following patch makes coreutils/test.c act fail gracefully if getgroups() returns a -1. This fixes a problem on the One Laptop Per Child ROM image whereby we were getting odd Memory exhausted messages for '[' and 'test'.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

coreutils/test.c +5 -3

coreutils/test.c+5 -3

@@ -151,7 +151,7 @@ typedef int arith_t;

	static char **t_wp;
	static struct t_op const *t_wp_op;
-	static gid_t *group_array = NULL;
+	static gid_t *group_array;
	static int ngroups;

	static enum token t_lex(char *s);
@@ -547,8 +547,10 @@ static int test_eaccess(char *path, int mode)
	static void initialize_group_array(void)
	{
	ngroups = getgroups(0, NULL);
-	group_array = xrealloc(group_array, ngroups * sizeof(gid_t));
-	getgroups(ngroups, group_array);
+	if (ngroups > 0) {
+	group_array = xmalloc(ngroups * sizeof(gid_t));
+	getgroups(ngroups, group_array);
+	}
	}

	/* Return non-zero if GID is one that we have in our groups list. */