← Commit list

ed7d118dd

Denys Vlasenko
Denys Vlasenko
2017-08-06
SUCCESS Duration: 142s

Subject

adjtimex: make it NOFORK

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

NOFORK_NOEXEC.lst+1 -1
@@ -39,7 +39,7 @@ acpid - daemon
add-shell
addgroup
adduser
-adjtimex
+adjtimex - NOFORK
ar - runner
arch - NOFORK
arp - complex, rare
miscutils/adjtimex.c+6 -1
@@ -18,7 +18,7 @@
//config: Adjtimex reads and optionally sets adjustment parameters for
//config: the Linux clock adjustment algorithm.
-//applet:IF_ADJTIMEX(APPLET(adjtimex, BB_DIR_SBIN, BB_SUID_DROP))
+//applet:IF_ADJTIMEX(APPLET_NOFORK(adjtimex, adjtimex, BB_DIR_SBIN, BB_SUID_DROP, adjtimex))
//kbuild:lib-$(CONFIG_ADJTIMEX) += adjtimex.o
@@ -116,6 +116,11 @@ int adjtimex_main(int argc UNUSED_PARAM, char **argv)
txc.modes |= ADJ_TICK;
}
+ /* It's NOFORK applet because the code is very simple:
+ * just some printf. No opens, no allocs.
+ * If you need to make it more complex, feel free to downgrade to NOEXEC
+ */
+
ret = adjtimex(&txc);
if (ret < 0)
bb_perror_nomsg_and_die();