f4b273cbb

Eric Andersen

2002-12-11

SOURCE BUG Duration: 5s

Subject

A cleaner cleanup that avoids passing an off_t to scanf

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): sysdeps/linux/Config.in "fileutils/Config.in" dosyasini kaynak gosteriyor ama bu dosya repoda hic var olmadi (2002-12-05 - 2003-02-15 arasi orijinal yazar hatasi, 3238ea167 ile duzeltildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

archival/libunarchive/get_header_cpio.c +9 -5

archival/libunarchive/get_header_cpio.c+9 -5

@@ -85,11 +85,15 @@ extern char get_header_cpio(archive_handle_t *archive_handle)
	error_msg_and_die("Unsupported cpio format, use newc or crc");
	}

-	sscanf(cpio_header, "%6c%8x%8x%8x%8x%8x%8lx%8lx%16c%8x%8x%8x%8c",
-	dummy, &inode, (unsigned int*)&file_header->mode,
-	(unsigned int)&file_header->uid, (unsigned int)&file_header->gid,
-	&nlink, &file_header->mtime, (unsigned long*)&file_header->size,
-	dummy, &major, &minor, &namesize, dummy);
+	{
+	unsigned long tmpsize;
+	sscanf(cpio_header, "%6c%8x%8x%8x%8x%8x%8lx%8lx%16c%8x%8x%8x%8c",
+	dummy, &inode, (unsigned int*)&file_header->mode,
+	(unsigned int)&file_header->uid, (unsigned int)&file_header->gid,
+	&nlink, &file_header->mtime, &tmpsize,
+	dummy, &major, &minor, &namesize, dummy);
+	file_header->size = tmpsize;
+	}

	file_header->name = (char *) xmalloc(namesize + 1);
	archive_xread_all(archive_handle, file_header->name, namesize); /* Read in filename */