← Commit list

f4e4563fe

Denis Vlasenko
Denis Vlasenko
2009-04-26
FAILED Duration: 37s

Subject

ifplugd: add copyright

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/ifplugd.c+16 -1
@@ -2,7 +2,7 @@
/*
* ifplugd for busybox
*
- * Copyright (C) 2009
+ * Copyright (C) 2009 Maksym Kryzhanovskyy <[email protected]>
*
* Licensed under GPLv2 or later, see file LICENSE in this tarball for details.
*/
@@ -19,6 +19,21 @@
#define __user
#include <linux/wireless.h>
+/*
+TODO: describe compat status here.
+
+One questionable point of the design is netlink usage:
+
+We have 1 second timeout by default to poll the link status,
+it is short enough so that there are no real benefits in
+using netlink to get "instantaneous" interface creation/deletion
+notifications. We can check for interface existence by just
+doing some fast ioctl using its name.
+
+Netlink code then can be just dropped (1k or more?)
+*/
+
+
#define IFPLUGD_ENV_PREVIOUS "IFPLUGD_PREVIOUS"
#define IFPLUGD_ENV_CURRENT "IFPLUGD_CURRENT"