fb8c4983a

Rob Landley

2006-01-09

SOURCE BUG Duration: 16s

Subject

Fix bug 603: "chown :root thingy" should work now.

SOURCE BUG

This commit was genuinely broken at the time (not related to our build system): scripts/config/mkconfigs.c (2005-08-01 - 2006-10-05 arasi) uretilen bbconfigopts.h icine .config satirlarini kacissiz, ham newline'larla gömüyordu - gecerli C degildi, busybox'un kendi bb_mkdep araci bile parse edemiyordu (7d219aab7 ile duzeltildi, mkconfigs shell scripte cevrildi)

→ Bu hatanin tam hikayesini ve duzeltme diffini gor

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

coreutils/chown.c +4 -7

coreutils/chown.c+4 -7

@@ -17,8 +17,8 @@
	#include <string.h>
	#include "busybox.h"

-	static long uid;
-	static long gid;
+	static uid_t uid = -1;
+	static gid_t gid = -1;

	static int (chown_func)(const char , uid_t, gid_t) = chown;

@@ -57,15 +57,12 @@ int chown_main(int argc, char **argv)
	groupName = strchr(*argv, ':');
	}

-	gid = -1;
+	/* Check for the username and groupname */
	if (groupName) {
	*groupName++ = '\0';
	gid = get_ug_id(groupName, bb_xgetgrnam);
	}
-
-	/* Now check for the username */
-	uid = get_ug_id(*argv, bb_xgetpwnam);
-
+	if (--groupName != argv) uid = get_ug_id(argv, bb_xgetpwnam);
	++argv;

	/* Ok, ready to do the deed now */