fc78b7957

Robert Griebl

2002-07-19

FAILED Duration: 7s

Subject

Applied syslogd fix submitted by Bart Visscher: I am using BB 0.60.2 in a floppy distro, and the syslog (and logger) is unable to log the "<" char. This shows up in ppp logfiles. [...] #logger "" results in "comp>" arriving at the log.

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

sysklogd/syslogd.c +3 -1

sysklogd/syslogd.c+3 -1

@@ -411,14 +411,16 @@ static int serveConnection (int conn)
	int pri = (LOG_USER \| LOG_NOTICE);
	char line[ BUFSIZE + 1 ];
	unsigned char c;
+	int gotpri = 0;

	char *q = line;

	tmpbuf[ n_read - 1 ] = '\0';

	while (p && (c = *p) && q < &line[ sizeof (line) - 1 ]) {
-	if (c == '<') {
+	if ((c == '<') && !gotpri && isdigit(p[1])) {
	/* Parse the magic priority number. */
+	gotpri = 1;
	pri = 0;
	while (isdigit (*(++p))) {
	pri = 10 * pri + (*p - '0');