← Commit list

fcc634797

Denis Vlasenko
Denis Vlasenko
2008-04-10
FAILED Duration: 19s

Subject

udhcp,ipcalc: simple code shrink (Nico Erfurth )

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

networking/ipcalc.c+2 -5
@@ -175,16 +175,13 @@ int ipcalc_main(int argc, char **argv)
if (opt & HOSTNAME) {
struct hostent *hostinfo;
- int x;
hostinfo = gethostbyaddr((char *) &ipaddr, sizeof(ipaddr), AF_INET);
if (!hostinfo) {
bb_herror_msg_and_die("cannot find hostname for %s", argv[0]);
}
- for (x = 0; hostinfo->h_name[x]; x++) {
- hostinfo->h_name[x] = tolower(hostinfo->h_name[x]);
- }
-
+ str_tolower(hostinfo->h_name);
+
printf("HOSTNAME=%s\n", hostinfo->h_name);
}
}
networking/udhcp/files.c+1 -3
@@ -26,13 +26,11 @@ static int read_ip(const char *line, void *arg)
static int read_mac(const char *line, void *arg)
{
- uint8_t *mac_bytes = arg;
struct ether_addr *temp_ether_addr;
- temp_ether_addr = ether_aton(line);
+ temp_ether_addr = ether_aton_r(line, (struct ether_addr *)arg);
if (temp_ether_addr == NULL)
return 0;
- memcpy(mac_bytes, temp_ether_addr, 6);
return 1;
}