fe1ef2bc6
Eric Andersen
2002-06-06
Subject
Fix buffer overflows noted by Gerardo Puga -Erik
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
miscutils/makedevs.c+5 -1
| @@ -52,9 +52,13 @@ int makedevs_main(int argc, char **argv) | |
| if (type[0] != 'f') | |
| dev = (major << 8) | Sminor; | |
| - | strcpy(devname, basedev); |
| + | safe_strncpy(devname, basedev, sizeof(devname)); |
| if (sbase == 0) { | |
| + | int len; |
| + | len = strlen(devname); |
| + | if (S > 10000 || len > (sizeof(devname)-6)) |
| + | error_msg_and_die("%s: number too large", buf); |
| sprintf(buf, "%d", S); | |
| strcat(devname, buf); | |
| } else { | |