feb79e874
Denys Vlasenko
2017-08-05
Subject
cryptpw, mkpasswd: make them NOEXEC
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
NOFORK_NOEXEC.lst+2 -2
| @@ -79,7 +79,7 @@ cp - noexec. runner | |
| cpio - runner | |
| crond - daemon | |
| crontab 0 leaks: open+xasprintf | |
| - | cryptpw - changes state: with --password-fd=N, moves N to stdin. Also, "rare" category. noexec candidate. |
| + | cryptpw - noexec. changes state: with --password-fd=N, moves N to stdin |
| cttyhack - noexec. spawner | |
| cut - noexec. runner | |
| date - noexec. nofork candidate(needs to stop messing up env, free xasprintf result, not use xfuncs after xasprintf) | |
| @@ -229,7 +229,7 @@ mkfs.ext2 - needs ^C | |
| mkfs.minix - needs ^C | |
| mkfs.vfat - needs ^C | |
| mknod - noexec | |
| - | mkpasswd - changes state: with --password-fd=N, moves N to stdin. Also, "rare" category. noexec candidate. |
| + | mkpasswd - noexec. changes state: with --password-fd=N, moves N to stdin |
| mkswap - needs ^C | |
| mktemp - noexec. leaks: xstrdup+concat_path_file | |
| modinfo - noexec | |
loginutils/cryptpw.c+3 -3
| @@ -24,9 +24,9 @@ | |
| //config: using the given salt. Debian has this utility under mkpasswd | |
| //config: name. Busybox provides mkpasswd as an alias for cryptpw. | |
| - | //applet:IF_CRYPTPW(APPLET(cryptpw, BB_DIR_USR_BIN, BB_SUID_DROP)) |
| - | // APPLET_ODDNAME:name main location suid_type help |
| - | //applet:IF_MKPASSWD(APPLET_ODDNAME(mkpasswd, cryptpw, BB_DIR_USR_BIN, BB_SUID_DROP, cryptpw)) |
| + | //applet:IF_CRYPTPW( APPLET_NOEXEC(cryptpw, cryptpw, BB_DIR_USR_BIN, BB_SUID_DROP, cryptpw)) |
| + | // APPLET_NOEXEC:name main location suid_type help |
| + | //applet:IF_MKPASSWD(APPLET_NOEXEC(mkpasswd, cryptpw, BB_DIR_USR_BIN, BB_SUID_DROP, cryptpw)) |
| //kbuild:lib-$(CONFIG_CRYPTPW) += cryptpw.o | |
| //kbuild:lib-$(CONFIG_MKPASSWD) += cryptpw.o | |