← Commit list

10bac43b87

Viktor Szakats
Viktor Szakats
2025-09-30
FAILED Duration: 179s

Subject

tests/server: drop unsafe `open()` override in signal handler (Windows)

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

tests/server/util.c+3 -3
@@ -373,12 +373,12 @@ static void exit_signal_handler(int signum)
(void)!write(STDERR_FILENO, msg, sizeof(msg) - 1);
}
else {
+ int fd;
#ifdef _WIN32
-#define OPENMODE S_IREAD | S_IWRITE
+ fd = _open(serverlogfile, O_WRONLY|O_CREAT|O_APPEND, S_IREAD | S_IWRITE);
#else
-#define OPENMODE S_IRUSR | S_IWUSR
+ fd = open(serverlogfile, O_WRONLY|O_CREAT|O_APPEND, S_IRUSR | S_IWUSR);
#endif
- int fd = open(serverlogfile, O_WRONLY|O_CREAT|O_APPEND, OPENMODE);
if(fd != -1) {
static const char msg[] = "exit_signal_handler: called\n";
(void)!write(fd, msg, sizeof(msg) - 1);