← Commit list

254e04b702

Viktor Szakats
Viktor Szakats
2025-11-03
SUCCESS Duration: 154s

Subject

ftpserver.pl: fix newlines in 227/229 replies, adjust tests

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

tests/data/test1349 +1 -1tests/data/test1350 +1 -1tests/data/test1351 +1 -1tests/data/test1352 +1 -1tests/data/test1353 +1 -1tests/data/test1354 +1 -1tests/data/test1357 +1 -1tests/data/test1358 +1 -1tests/data/test1359 +1 -1tests/data/test1360 +1 -1tests/data/test1361 +1 -1tests/data/test1362 +1 -1tests/data/test1379 +1 -1tests/data/test1380 +1 -1tests/data/test1381 +1 -1tests/data/test1382 +1 -1tests/data/test1383 +1 -1tests/data/test1384 +1 -1tests/data/test1387 +1 -1tests/data/test1388 +1 -1tests/data/test1389 +1 -1tests/data/test1390 +1 -1tests/data/test1391 +1 -1tests/data/test1392 +1 -1tests/ftpserver.pl +2 -2
tests/data/test1349+1 -1
@@ -58,7 +58,7 @@ mooo
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 10
150 Binary data connection for %TESTNUMBER () (10 bytes).
tests/data/test1350+1 -1
@@ -58,7 +58,7 @@ mooo
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 10
150 Binary data connection for %TESTNUMBER () (10 bytes).
tests/data/test1351+1 -1
@@ -59,7 +59,7 @@ mooo
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 10
150 Binary data connection for %TESTNUMBER () (10 bytes).
tests/data/test1352+1 -1
@@ -59,7 +59,7 @@ mooo
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 10
150 Binary data connection for %TESTNUMBER () (10 bytes).
tests/data/test1353+1 -1
@@ -58,7 +58,7 @@ mooo
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 10
150 Binary data connection for %TESTNUMBER () (10 bytes).
tests/data/test1354+1 -1
@@ -56,7 +56,7 @@ mooo
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 10
150 Binary data connection for %TESTNUMBER () (10 bytes).
tests/data/test1357+1 -1
@@ -71,7 +71,7 @@ MOOOO
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 214
150 Binary data connection for %TESTNUMBER () (214 bytes).
tests/data/test1358+1 -1
@@ -71,7 +71,7 @@ MOOOO
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 214
150 Binary data connection for %TESTNUMBER () (214 bytes).
tests/data/test1359+1 -1
@@ -72,7 +72,7 @@ MOOOO
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 214
150 Binary data connection for %TESTNUMBER () (214 bytes).
tests/data/test1360+1 -1
@@ -72,7 +72,7 @@ MOOOO
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 214
150 Binary data connection for %TESTNUMBER () (214 bytes).
tests/data/test1361+1 -1
@@ -71,7 +71,7 @@ MOOOO
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 214
150 Binary data connection for %TESTNUMBER () (214 bytes).
tests/data/test1362+1 -1
@@ -71,7 +71,7 @@ MOOOO
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 214
150 Binary data connection for %TESTNUMBER () (214 bytes).
tests/data/test1379+1 -1
@@ -56,7 +56,7 @@ mooo
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 10
150 Binary data connection for %TESTNUMBER () (10 bytes).
tests/data/test1380+1 -1
@@ -56,7 +56,7 @@ mooo
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 10
150 Binary data connection for %TESTNUMBER () (10 bytes).
tests/data/test1381+1 -1
@@ -57,7 +57,7 @@ mooo
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 10
150 Binary data connection for %TESTNUMBER () (10 bytes).
tests/data/test1382+1 -1
@@ -57,7 +57,7 @@ mooo
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 10
150 Binary data connection for %TESTNUMBER () (10 bytes).
tests/data/test1383+1 -1
@@ -56,7 +56,7 @@ mooo
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 10
150 Binary data connection for %TESTNUMBER () (10 bytes).
tests/data/test1384+1 -1
@@ -56,7 +56,7 @@ mooo
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 10
150 Binary data connection for %TESTNUMBER () (10 bytes).
tests/data/test1387+1 -1
@@ -71,7 +71,7 @@ MOOOO
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 222
150 Binary data connection for %TESTNUMBER () (222 bytes).
tests/data/test1388+1 -1
@@ -71,7 +71,7 @@ MOOOO
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 222
150 Binary data connection for %TESTNUMBER () (222 bytes).
tests/data/test1389+1 -1
@@ -72,7 +72,7 @@ MOOOO
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 222
150 Binary data connection for %TESTNUMBER () (222 bytes).
tests/data/test1390+1 -1
@@ -72,7 +72,7 @@ MOOOO
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 222
150 Binary data connection for %TESTNUMBER () (222 bytes).
tests/data/test1391+1 -1
@@ -71,7 +71,7 @@ MOOOO
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 222
150 Binary data connection for %TESTNUMBER () (222 bytes).
tests/data/test1392+1 -1
@@ -71,7 +71,7 @@ MOOOO
230 Welcome you silly person
257 "/" is current directory
250 CWD command successful.
-229 Entering Passive Mode (stripped)
+229 Entering Passive Mode (stripped)
200 I modify TYPE as you wanted
213 222
150 Binary data connection for %TESTNUMBER () (222 bytes).
tests/ftpserver.pl+2 -2
@@ -2566,12 +2566,12 @@ sub PASV_ftp {
if($pasvbadip) {
$p="1,2,3,4";
}
- sendcontrol sprintf("227 Entering Passive Mode ($p,%d,%d)\n",
+ sendcontrol sprintf("227 Entering Passive Mode ($p,%d,%d)\r\n",
int($pasvport/256), int($pasvport%256));
}
else {
# EPSV reply
- sendcontrol sprintf("229 Entering Passive Mode (|||%d|)\n", $pasvport);
+ sendcontrol sprintf("229 Entering Passive Mode (|||%d|)\r\n", $pasvport);
}
logmsg "Client has been notified that DATA conn ".