2862cafb49
Viktor Szakats
2026-02-20
Subject
unit1654: fix clang-tidy `bugprone-redundant-branch-condition`
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
.clang-tidy.yml+1 -0
| @@ -10,6 +10,7 @@ Checks: | |
| - -clang-analyzer-security.insecureAPI.bzero # for FD_ZERO() (seen on macOS) | |
| - -clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling | |
| - -clang-diagnostic-nullability-extension | |
| + | - bugprone-redundant-branch-condition |
| - bugprone-suspicious-realloc-usage | |
| - misc-const-correctness | |
| - misc-header-include-cycle | |
tests/unit/unit1654.c+4 -6
| @@ -37,16 +37,14 @@ static CURLcode test_unit1654(const char *arg) | |
| struct altsvcinfo *asi = Curl_altsvc_init(); | |
| abort_if(!asi, "Curl_altsvc_i"); | |
| result = Curl_altsvc_load(asi, arg); | |
| - | if(result) { |
| - | fail_if(result, "Curl_altsvc_load"); |
| + | fail_if(result, "Curl_altsvc_load"); |
| + | if(result) |
| goto fail; | |
| - | } |
| curl_global_init(CURL_GLOBAL_ALL); | |
| curl = curl_easy_init(); | |
| - | if(!curl) { |
| - | fail_if(!curl, "curl_easy_init"); |
| + | fail_if(!curl, "curl_easy_init"); |
| + | if(!curl) |
| goto fail; | |
| - | } |
| fail_unless(Curl_llist_count(&asi->list) == 4, "wrong number of entries"); | |
| curl_msnprintf(outname, sizeof(outname), "%s-out", arg); | |