4e5908306a

Viktor Szakats

2026-01-25

SUCCESS Duration: 330s

Subject

build: constify `memchr()`/`strchr()`/etc result variables (cont.)

No binary (build failed)

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

(log yok)

lib/dict.c+1 -1

@@ -136,7 +136,7 @@ static CURLcode sendf(struct Curl_easy data, const char fmt, ...)

	static CURLcode dict_do(struct Curl_easy data, bool done)
	{
-	const char *word;
+	char *word;
	char *eword = NULL;
	char *ppath;
	char *database = NULL;

lib/http_digest.c+1 -1

@@ -69,7 +69,7 @@ CURLcode Curl_output_digest(struct Curl_easy *data,
	{
	CURLcode result;
	unsigned char *path = NULL;
-	char *tmp = NULL;
+	const char *tmp = NULL;
	char *response;
	size_t len;
	bool have_chlg;

src/tool_operhlp.c+1 -1

@@ -116,7 +116,7 @@ CURLcode add_file_name_to_url(CURL curl, char inurlp, const char filename)
	/* We only want the part of the local path that is on the right
	side of the rightmost slash and backslash. */
	const char *filep = strrchr(filename, '/');
-	char *file2 = strrchr(filep ? filep : filename, '\\');
+	const char *file2 = strrchr(filep ? filep : filename, '\\');
	char *encfile;

	if(file2)

src/tool_urlglob.c+1 -1

@@ -352,7 +352,7 @@ static CURLcode peek_ipv6(const char str, size_t skip, bool *ipv6p)
	*/
	char hostname[MAX_IP6LEN];
	CURLU *u;
-	char *endbr = strchr(str, ']');
+	const char *endbr = strchr(str, ']');
	size_t hlen;
	CURLUcode rc;
	CURLcode result = CURLE_OK;

src/tool_writeout.c+2 -2

@@ -734,10 +734,10 @@ void ourWriteOut(struct OperationConfig config, struct per_transfer per,
	}
	else {
	/* this is meant as a variable to output */
-	char *end;
+	const char *end;
	size_t vlen;
	if('{' == ptr[1]) {
-	struct writeoutvar *wv = NULL;
+	const struct writeoutvar *wv = NULL;
	struct writeoutvar find = { 0 };
	end = strchr(ptr, '}');
	ptr += 2; /* pass the % and the { */

tests/libtest/lib1560.c+1 -1

@@ -1185,7 +1185,7 @@ static CURLUcode updateurl(CURLU u, const char cmd, unsigned int setflags)

	/* make sure the last command ends with a comma too! */
	while(p) {
-	char *e = strchr(p, ',');
+	const char *e = strchr(p, ',');
	if(e) {
	size_t n = (size_t)(e - p);
	char buf[80];

tests/server/sws.c+2 -2

@@ -491,7 +491,7 @@ static int sws_ProcessRequest(struct sws_httprequest *req)

	if(req->testno == DOCNUMBER_NOTHING) {
	/* check for a Testno: header with the test case number */
-	char *testno = strstr(line, "\nTestno: ");
+	const char *testno = strstr(line, "\nTestno: ");
	if(testno) {
	pval = &testno[9];
	if(!curlx_str_number(&pval, &num, INT_MAX)) {
@@ -596,7 +596,7 @@ static int sws_ProcessRequest(struct sws_httprequest *req)
	return 1; /* done */
	}
	else if(strstr(req->reqbuf, "\r\n0\r\n")) {
-	char *last_crlf_char = strstr(req->reqbuf, "\r\n\r\n");
+	const char *last_crlf_char = strstr(req->reqbuf, "\r\n\r\n");
	while(TRUE) {
	if(!strstr(last_crlf_char + 4, "\r\n\r\n"))
	break;