532d134767
Viktor Szakats
2025-12-24
Subject
build: stop disabling `strcpy` checks with clang-tidy
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
.github/workflows/linux.yml+1 -1
| @@ -37,7 +37,7 @@ env: | |
| MAKEFLAGS: -j 5 | |
| CURL_CI: github | |
| CURL_TEST_MIN: 1600 | |
| - | CURL_CLANG_TIDYFLAGS: '-checks=-clang-analyzer-security.insecureAPI.bzero,-clang-analyzer-security.insecureAPI.strcpy,-clang-analyzer-optin.performance.Padding,-clang-analyzer-security.ArrayBound,-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,-clang-analyzer-valist.Uninitialized' |
| + | CURL_CLANG_TIDYFLAGS: '-checks=-clang-analyzer-security.insecureAPI.bzero,-clang-analyzer-optin.performance.Padding,-clang-analyzer-security.ArrayBound,-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling,-clang-analyzer-valist.Uninitialized' |
| # renovate: datasource=github-tags depName=libressl/portable versioning=semver registryUrl=https://github.com | |
| LIBRESSL_VERSION: 4.2.1 | |
| # renovate: datasource=github-tags depName=wolfSSL/wolfssl versioning=semver extractVersion=^v?(?<version>.+)-stable$ registryUrl=https://github.com | |
CMakeLists.txt+0 -1
| @@ -269,7 +269,6 @@ if(CURL_CLANG_TIDY) | |
| set(CURL_DISABLE_TYPECHECK ON) # to improve performance and avoid potential interference. | |
| set(_tidy_checks "") | |
| list(APPEND _tidy_checks "-clang-analyzer-security.insecureAPI.bzero") # for FD_ZERO() (seen on macOS) | |
| - | list(APPEND _tidy_checks "-clang-analyzer-security.insecureAPI.strcpy") |
| list(APPEND _tidy_checks "-clang-analyzer-optin.performance.Padding") | |
| list(APPEND _tidy_checks "-clang-analyzer-security.ArrayBound") # false positives with clang-tidy v21.1.0 | |
| list(APPEND _tidy_checks "-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling") | |
lib/Makefile.am+1 -1
| @@ -168,7 +168,7 @@ $(UNITPROTOS): $(CSOURCES) | |
| $(UNIT_V)(cd $(srcdir) && @PERL@ ../scripts/extract-unit-protos $(CSOURCES)) > $(top_builddir)/lib/$(UNITPROTOS) | |
| # disable the tests that are mostly causing false positives | |
| - | TIDYFLAGS := -checks=-clang-analyzer-security.insecureAPI.bzero,-clang-analyzer-security.insecureAPI.strcpy,-clang-analyzer-optin.performance.Padding,-clang-analyzer-security.ArrayBound,-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling -quiet |
| + | TIDYFLAGS := -checks=-clang-analyzer-security.insecureAPI.bzero,-clang-analyzer-optin.performance.Padding,-clang-analyzer-security.ArrayBound,-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling -quiet |
| if CURL_WERROR | |
| TIDYFLAGS += --warnings-as-errors=* | |
| endif | |
src/Makefile.am+1 -1
| @@ -219,7 +219,7 @@ endif | |
| endif | |
| # disable the tests that are mostly causing false positives | |
| - | TIDYFLAGS := -checks=-clang-analyzer-security.insecureAPI.bzero,-clang-analyzer-security.insecureAPI.strcpy,-clang-analyzer-optin.performance.Padding,-clang-analyzer-security.ArrayBound,-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling -quiet |
| + | TIDYFLAGS := -checks=-clang-analyzer-security.insecureAPI.bzero,-clang-analyzer-optin.performance.Padding,-clang-analyzer-security.ArrayBound,-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling -quiet |
| if CURL_WERROR | |
| TIDYFLAGS += --warnings-as-errors=* | |
| endif | |