← Commit list

576f9f7c07

Daniel Stenberg
Daniel Stenberg
2025-10-24
SUCCESS Duration: 161s

Subject

cfilters: check return code from Curl_pollset_set_out_only()

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

lib/cfilters.c+3 -2
@@ -542,8 +542,9 @@ CURLcode Curl_conn_connect(struct Curl_easy *data,
Curl_pollfds_reset(&cpfds);
/* In general, we want to send after connect, wait on that. */
if(sockfd != CURL_SOCKET_BAD)
- Curl_pollset_set_out_only(data, &ps, sockfd);
- result = Curl_conn_adjust_pollset(data, data->conn, &ps);
+ result = Curl_pollset_set_out_only(data, &ps, sockfd);
+ if(!result)
+ result = Curl_conn_adjust_pollset(data, data->conn, &ps);
if(result)
goto out;
result = Curl_pollfds_add_ps(&cpfds, &ps);
lib/select.h+3 -2
@@ -154,11 +154,12 @@ void Curl_pollset_move(struct easy_pollset *to, struct easy_pollset *from);
*/
CURLcode Curl_pollset_change(struct Curl_easy *data,
struct easy_pollset *ps, curl_socket_t sock,
- int add_flags, int remove_flags);
+ int add_flags,
+ int remove_flags) WARN_UNUSED_RESULT;
CURLcode Curl_pollset_set(struct Curl_easy *data,
struct easy_pollset *ps, curl_socket_t sock,
- bool do_in, bool do_out);
+ bool do_in, bool do_out) WARN_UNUSED_RESULT;
#define Curl_pollset_add_in(data, ps, sock) \
Curl_pollset_change((data), (ps), (sock), CURL_POLL_IN, 0)