59405ffb7d
Viktor Szakats
2026-03-19
Subject
build: enable `-Wimplicit-int-enum-cast` compiler warning, fix issues
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
CMake/PickyWarnings.cmake +1 -0lib/vssh/libssh2.c +1 -1m4/curl-compilers.m4 +1 -0tests/libtest/cli_hx_download.c +2 -1
CMake/PickyWarnings.cmake+1 -0
| @@ -258,6 +258,7 @@ if(PICKY_COMPILER) | |
| list(APPEND _picky_enable | |
| -Warray-compare # clang 20.1 gcc 12.0 appleclang 26.4 | |
| -Wc++-hidden-decl # clang 21.1 appleclang 26.4 | |
| + | -Wimplicit-int-enum-cast # clang 21.1 |
| -Wjump-misses-init # clang 21.1 gcc 4.5 appleclang 26.4 | |
| -Wno-implicit-void-ptr-cast # clang 21.1 appleclang 26.4 | |
| -Wtentative-definition-compat # clang 21.1 appleclang 26.4 | |
lib/vssh/libssh2.c+1 -1
| @@ -1157,7 +1157,7 @@ static CURLcode ssh_state_pkey_init(struct Curl_easy *data, | |
| else { | |
| myssh_to(data, sshc, SSH_AUTH_PASS_INIT); | |
| } | |
| - | return 0; |
| + | return CURLE_OK; |
| } | |
| static CURLcode sftp_quote_stat(struct Curl_easy *data, | |
m4/curl-compilers.m4+1 -0
| @@ -952,6 +952,7 @@ AC_DEFUN([CURL_SET_COMPILER_WARNING_OPTS], [ | |
| dnl clang 21 or later | |
| if test "$compiler_num" -ge "2101"; then | |
| CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [c++-hidden-decl]) | |
| + | CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [implicit-int-enum-cast]) |
| CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [jump-misses-init]) | |
| tmp_CFLAGS="$tmp_CFLAGS -Wno-implicit-void-ptr-cast" | |
| CURL_ADD_COMPILER_WARNINGS([tmp_CFLAGS], [tentative-definition-compat]) | |
tests/libtest/cli_hx_download.c+2 -1
| @@ -175,7 +175,8 @@ static int my_progress_d_cb(void *userdata, | |
| #endif | |
| #ifdef USE_GNUTLS | |
| case CURLSSLBACKEND_GNUTLS: { | |
| - | int v = gnutls_protocol_get_version((gnutls_session_t)tls->internals); |
| + | gnutls_protocol_t v = gnutls_protocol_get_version( |
| + | (gnutls_session_t)tls->internals); |
| assert(v); | |
| curl_mfprintf(stderr, "[t-%zu] info GnuTLS using %s\n", | |
| t->idx, gnutls_protocol_get_name(v)); | |