← Commit list

61dcb56743

Daniel Stenberg
Daniel Stenberg
2025-10-14
SUCCESS Duration: 184s

Subject

openldap: explain a const removing typecast

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

lib/openldap.c+4 -0
@@ -468,6 +468,10 @@ static CURLcode oldap_perform_mechs(struct Curl_easy *data)
if(!li)
return CURLE_FAILED_INIT;
+ /* Casting away the const for the 3rd parameter that the LDAP API expects as
+ a non-const char ** is potentially unsafe but we believe the lack of
+ const in the API was an oversight and that no LDAP implementation
+ actually modifies the input. */
rc = ldap_search_ext(li->ld, "", LDAP_SCOPE_BASE, "(objectclass=*)",
(char **)CURL_UNCONST(supportedSASLMechanisms), 0,
NULL, NULL, NULL, 0, &li->msgid);