7f19fa9819
Daniel Stenberg
2025-10-19
Subject
lib: add asserts that hostname has content
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
lib/doh.c+1 -0
| @@ -458,6 +458,7 @@ struct Curl_addrinfo *Curl_doh(struct Curl_easy *data, | |
| DEBUGASSERT(conn); | |
| DEBUGASSERT(!data->state.async.doh); | |
| + | DEBUGASSERT(hostname && hostname[0]); |
| if(data->state.async.doh) | |
| Curl_doh_cleanup(data); | |
lib/hostip.c+3 -1
| @@ -858,6 +858,7 @@ CURLcode Curl_resolv(struct Curl_easy *data, | |
| /* We should intentionally error and not resolve .onion TLDs */ | |
| hostname_len = strlen(hostname); | |
| + | DEBUGASSERT(hostname_len); |
| if(hostname_len >= 7 && | |
| (curl_strequal(&hostname[hostname_len - 6], ".onion") || | |
| curl_strequal(&hostname[hostname_len - 7], ".onion."))) { | |
| @@ -982,7 +983,7 @@ CURLcode Curl_resolv_blocking(struct Curl_easy *data, | |
| struct Curl_dns_entry **dnsentry) | |
| { | |
| CURLcode result; | |
| - | |
| + | DEBUGASSERT(hostname && *hostname); |
| *dnsentry = NULL; | |
| result = Curl_resolv(data, hostname, port, ip_version, FALSE, dnsentry); | |
| switch(result) { | |
| @@ -1060,6 +1061,7 @@ CURLcode Curl_resolv_timeout(struct Curl_easy *data, | |
| #endif /* USE_ALARM_TIMEOUT */ | |
| CURLcode result; | |
| + | DEBUGASSERT(hostname && *hostname); |
| *entry = NULL; | |
| if(timeoutms < 0) | |
lib/socks.c+2 -0
| @@ -331,6 +331,7 @@ static CURLproxycode socks4_resolving(struct socks_state *sx, | |
| if(sx->start_resolving) { | |
| /* need to resolve hostname to add destination address */ | |
| sx->start_resolving = FALSE; | |
| + | DEBUGASSERT(sx->hostname && *sx->hostname); |
| result = Curl_resolv(data, sx->hostname, sx->remote_port, | |
| cf->conn->ip_version, TRUE, &dns); | |
| @@ -858,6 +859,7 @@ static CURLproxycode socks5_resolving(struct socks_state *sx, | |
| if(sx->start_resolving) { | |
| /* need to resolve hostname to add destination address */ | |
| sx->start_resolving = FALSE; | |
| + | DEBUGASSERT(sx->hostname && *sx->hostname); |
| result = Curl_resolv(data, sx->hostname, sx->remote_port, | |
| cf->conn->ip_version, TRUE, &dns); | |